GH2533: Add new RawValue parameter to skip attribute value quoting #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlead
requested changes
Oct 26, 2019
src/Cake.Common/Solution/Project/Properties/AssemblyInfoCreatorData.cs
Outdated
Show resolved
Hide resolved
src/Cake.Common/Solution/Project/Properties/AssemblyInfoCreatorData.cs
Outdated
Show resolved
Hide resolved
|
Personally I think |
agc93
force-pushed
the
feature/GH-2533
branch
from
8e4af00
to
940661e
Compare
devlead
changed the title
devlead
force-pushed
the
feature/GH-2533
branch
from
940661e
to
338b8ff
Compare
|
@agc93 your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should solve #2533 in a more generic way. Rather than hardcoding for
SecurityRulesthis adds opt-in behaviour to skip attribute quoting.I'm not 100% sure on the whole "raw" naming, but I couldn't think of anything better. Other option would be to more explicit and use something like
NoQuote.